Skip to content

Conversation

@santysisi
Copy link
Contributor

Q A
Branch? 7.4
Bug fix? no
New feature? yes
Deprecations? yes
Issues no
License MIT

This PR adds a UriSignerInterface implemented by the existing UriSigner class.

The goal is to allow autoconfiguration based on the interface, enabling developers to provide custom UriSigner implementations without extending the core class. This follows feedback from previous discussions

@santysisi santysisi force-pushed the feature/uri-signer-interface branch from 25d547d to 0badb46 Compare September 15, 2025 03:59
@santysisi
Copy link
Contributor Author

status: needs work

I think there are related test failures. I will look into them as soon as possible

@nicolas-grekas
Copy link
Member

Let's close as discussed in #61756 (TL;DR, we'd need a realworld use case to support this)

@stof
Copy link
Member

stof commented Sep 15, 2025

@nicolas-grekas I would still add the interface, so that projects wanting to decorate/replace the main uri signer can implement that interface, instead of having to extend the original UriSigner (because the DI in the listener is not done against an interface right now).

@xabbuh
Copy link
Member

xabbuh commented Sep 15, 2025

I tend to agree with @stof. Being able to replace the one URI signer that is used across an application is a different (and more common) use case than being able to use different signers per controller.

@nicolas-grekas
Copy link
Member

Nah, same as on the other PR: what's the realworld use case?
The class is not final so we're not blocking anyone.
I'd wait for more feedback before adding more complexity to the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants