Replace __sleep/wakeup() by __(un)serialize() for throwing and internal usages #61727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
requested review from
dunglas,
jderusse,
xabbuh and
yceruto
as code owners
carsonbot
changed the title
nicolas-grekas
force-pushed
the
sleep-throw
branch
2 times, most recently
from
ef6aeb6 to
f068888
Compare
nicolas-grekas
force-pushed
the
sleep-throw
branch
from
f068888 to
ef4e3d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
__sleep/wakeup()by__(un)serialize(), for throwing and internal usages.This follows the merge of php/php-src#19435
While this change on 8.5 might be reverted (see https://wiki.php.net/rfc/soft-deprecate-sleep-wakeup), we can still remove all those cases.
This DOES NOT replace all use cases of
__sleep/wakeup(). We did so already on branch 7.4, but doing it on branch 6.4 is another story. This would basically be way to risky IMHO, with a bunch of non-trivial code to add just to fix the deprecation.My recommendation for those remaining use cases is to ignore the deprecation. By the time ppl will move to PHP 8.5, they will also move away from Symfony 6.4
I'll submit another PR to the phpunit-bridge for that.
For the record, here is the list of files/classes that cannot be "just" migrated to
__(un)serialize()(I'll let the reader wonder about how they could be - and compare their ideas to what we did in 7.4):