[Intl] Remove incorrect condition in CurrencyDataGenerator::icuPairToDate
#61681
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
…Date 1 << 63 === PHP_INT_MIN we cannot have a lower int value 1 << 64 === 0 so the removing this value doesn't change anything Fix psalm crash due to bug vimeo/psalm#11209 When doing PHP_INT_MIN - 1, the value is converted to a float that breaks the type system of psalm https://github.com/vimeo/psalm/blob/279f3eab037923d3f9d3ea3de1a16b425653e30c/src/Psalm/Internal/Type/SimpleAssertionReconciler.php#L2073
GromNaN
force-pushed
the
icuPairToDate
branch
from
a246fa6 to
7779ac1
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a psalm analysis issue by removing an unnecessary condition in the CurrencyDataGenerator::icuPairToDate method that was causing static analysis to crash. The removed condition was mathematically redundant since 1 << 63 === PHP_INT_MIN represents the lowest possible integer value, and 1 << 64 === 0, making the subtraction operation meaningless.
- Removes redundant signed/unsigned 64-bit integer conversion logic
- Fixes psalm static analysis crash related to integer overflow handling
- Maintains existing functionality while improving code analysis compatibility
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Thanks @GromNaN The fix seems correct to me. PHP seems to store the sign in the last bit. Therefore, when we do 1 << 63, PHP automatically transforms the value to a float instead of going in negative values for safety purpose. That was probably the reason why psalm was failing As you said, this is not an issue if we have a float for the following calculations as long as we don't reach the value (1 << 62) /1000 + 1 |
|
Thank you @GromNaN. |
4 participants
Remove a useless condition that breaks psalm analysis.
1 << 63 === PHP_INT_MINwe cannot have a lower int value1 << 64 === 0so the removing this value doesn't change anythingFix psalm crash due to bug vimeo/psalm#11209
When
PHP_INT_MIN - 1, the value is converted to a float that breaks the type system of psalm https://github.com/vimeo/psalm/blob/279f3eab037923d3f9d3ea3de1a16b425653e30c/src/Psalm/Internal/Type/SimpleAssertionReconciler.php#L2073Dealing with timestamp
>= (1 << 62)/1000will be necessary when we reach year 146140482.