[Intl] Add metadata about currencies' validity dates #61556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
intl-currencies
branch
from
cb75fce to
4a85bb3
Compare
nicolas-grekas
changed the title
Member
Author
|
Thank you @Crovitche-1623. |
GromNaN
reviewed
Sep 2, 2025
Comment on lines
+240
to
+242
| if ($unsigned64 >= (1 << 63)) { | ||
| $unsigned64 -= (1 << 64); | ||
| } |
Member
There was a problem hiding this comment.
The psalm job fails since this commit due to a bug: vimeo/psalm#11209
Member
There was a problem hiding this comment.
This condition is not necessary and the fix is not working. It can be removed: #61681
nicolas-grekas
added a commit
that referenced
this pull request
Sep 8, 2025
…tor::icuPairToDate` (GromNaN) This PR was merged into the 6.4 branch. Discussion ---------- [Intl] Remove incorrect condition in `CurrencyDataGenerator::icuPairToDate` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #61556 (comment) | License | MIT Remove a useless condition that breaks psalm analysis. - `1 << 63 === PHP_INT_MIN` we cannot have a lower int value - `1 << 64 === 0` so the removing this value doesn't change anything Fix psalm crash due to bug vimeo/psalm#11209 When `PHP_INT_MIN - 1`, the value is converted to a float that breaks the type system of psalm https://github.com/vimeo/psalm/blob/279f3eab037923d3f9d3ea3de1a16b425653e30c/src/Psalm/Internal/Type/SimpleAssertionReconciler.php#L2073 Dealing with timestamp `>= (1 << 62)/1000` will be necessary when we read [year 146140482](https://3v4l.org/AAKNt). Commits ------- 7779ac1 [Intl] Remove incorrect condition in CurrencyDataGenerator::icuPairToDate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports intl data from #61431 to 6.4
This also syncs the ICU compilation scripts with 7.4.
This allows generating ICU data once on 6.4 and not have to care about running that again on higher branches.