-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[WebProfilerBundle] Show APP_RUNTIME
#61508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebProfilerBundle] Show APP_RUNTIME
#61508
Conversation
src/Symfony/Component/HttpKernel/DataCollector/ConfigDataCollector.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/Tests/DataCollector/ConfigDataCollectorTest.php
Outdated
Show resolved
Hide resolved
|
If If the goal of this PR is only to display |
APP_RUNTIME
|
Hey thx for trying that |
- Resolve runtime from APP_RUNTIME, composer.json extra.runtime.class, or Symfony\Runtime\SymfonyRuntime - Expose via ConfigDataCollector::getAppRuntime and render in config.html.twig - Add tests for env/composer/fallback resolution
|
The PR now displays the resolved runtime class — it checks |
- Remove static cache from resolveAppRuntime() to avoid cross-test contamination
|
About the implementation, this relies too much on implementation details. BUT, I'm not sure what this info could be useful for. Any details about that? The runner might be a more useful thing to show, because then one can see if they're running frankenphp or etc. |
|
@nicolas-grekas ftr, when I created the issue I was testing locally frankenphp with worker mode, and wanted to check if the runtime was the proper one, and didnt saw any thing related in profiler, thus opening this issue |
|
OK, so showing the runtime won't help. The SymfonyRuntime is able to handle both PHP-FPM and frankenphp. |
|
Closing for history. PR welcome I suppose to show the runner instead. |
This PR adds support for displaying the
APP_RUNTIMEvalue in the Symfony Profiler configuration dashboard.Before
After
$_SERVER['APP_RUNTIME']is set, making it easier to debug and confirm the active runtime.Profiler UI