[Routing][Serializer] Deprecate annotation aliases and getters and setters in favor of public properties on attributes #61487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tters in favor of public properties on attributes
nicolas-grekas
added a commit
that referenced
this pull request
Aug 21, 2025
…tters and setters in favor of public properties on attributes (nicolas-grekas) This PR was merged into the 8.0 branch. Discussion ---------- [Routing][Serializer] Remove annotation aliases and getters and setters in favor of public properties on attributes | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT Follows #61487 Commits ------- 153ae98 [Routing][Serializer] Remove annotation aliases and getters and setters in favor of public properties on attributes
Kocal
added a commit
to symfony/ux
that referenced
this pull request
Aug 22, 2025
This PR was merged into the 2.x branch. Discussion ---------- Fix highest-deps job | Q | A | ------------- | --- | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Docs? | no <!-- required for new features --> | Issues | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT <!-- Replace this notice by a description of your feature/bugfix. This will help reviewers and should be a good start for the documentation. Additionally (see https://symfony.com/releases): - Always add tests and ensure they pass. - For new features, provide some code snippets to help understand usage. - Features and deprecations must be submitted against branch main. - Update/add documentation as required (we can help!) - Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry - Never break backward compatibility (see https://symfony.com/bc). --> Related to symfony/symfony#61488 & symfony/symfony#61487 Commits ------- 0d51a72 Fix highest-deps job
Contributor
|
A changelog has been removed by this PR: https://github.com/symfony/symfony/pull/61487/files#diff-e12f46870a296882778d874e36f57ed916484332b8d3ad0b349f5297712071e9L80 not sure if it was intentional. |
Member
|
I guess it should be added back |
Member
|
Re-reading the linked PR again I think the current way is correct. The changelog entries added there mention that all the getter and setter methods are deprecated (which includes |
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's remove more needless boilerplate.
These deprecations shouldn't affect anyone since I don't expected other code than ours to read these attributes.
Note that I don't make properties on
Routereadonly because of the existing setters.(Note also that having readonly on the other attribute properties isn't useful in pragmatic terms, that's mostly pedantic ;) )