[HttpFoundation][HttpKernel][WebProfilerBundle] Add support for the QUERY HTTP method
#61173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
query-method
branch
from
0cfd34f to
1618dbf
Compare
stof
requested changes
Jul 21, 2025
alexandre-daubois
force-pushed
the
query-method
branch
from
1618dbf to
92ec262
Compare
OskarStark
reviewed
Jul 21, 2025
Contributor
|
Should be updated to addQUERY to the list?
|
Member
Author
|
The same question applies to
I guess that if we may, we can fallback on |
alexandre-daubois
force-pushed
the
query-method
branch
from
92ec262 to
1deb7d3
Compare
Member
|
We should indeed parse a |
alexandre-daubois
force-pushed
the
query-method
branch
4 times, most recently
from
0201731 to
f9d9416
Compare
carsonbot
changed the title
QUERY HTTP methodQUERY HTTP method
alexandre-daubois
force-pushed
the
query-method
branch
from
f9d9416 to
619d156
Compare
Member
Author
|
PR updated. A follow-up PR would be to also support the method in HttpClient. I added support for the method also in WebProfilerBundle |
alexandre-daubois
force-pushed
the
query-method
branch
5 times, most recently
from
759bdfd to
c6c62e4
Compare
Member
Author
|
The tests are passing, but failing when reruned here. Not sure why though. Should we remove Status: Needs Review |
nicolas-grekas
approved these changes
Jul 22, 2025
fabpot
approved these changes
Aug 16, 2025
…QUERY` HTTP method
Member
|
Thank you @alexandre-daubois. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 15, 2025
…ethods (nicolas-grekas) This PR was merged into the 7.4 branch. Discussion ---------- [HttpClient] Add QUERY to the list of retriable HTTP methods | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | #60521 | License | MIT Similar to #61173 Commits ------- da60084 [HttpClient] Add QUERY to the list of retriable HTTP methods
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not much difference from
GET, appart that the request body is used to generate the cache key inHttpCache.Webprofiler integration: