[Validator] Add option to allow ANY protocol in Assert\Url constraint
#60561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Drkilla
force-pushed
the
feature/url-validator-allow-any-protocol
branch
from
2ea4167 to
879bdc3
Compare
OskarStark
changed the title
ANY protocol in Assert\Url constraint
Drkilla
force-pushed
the
feature/url-validator-allow-any-protocol
branch
from
b68021b to
ed1178c
Compare
fabpot
approved these changes
Sep 22, 2025
fabpot
force-pushed
the
feature/url-validator-allow-any-protocol
branch
from
ed1178c to
d8b7f62
Compare
Member
|
Thank you @Drkilla. |
This was referenced Sep 24, 2025
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Sep 24, 2025
…(xabbuh) This PR was merged into the 7.4 branch. Discussion ---------- [Validator] allow the asterisk to be passed as a string | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT making #60561 easier to use Commits ------- a91e0ce allow protocols to be passed as a string
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.