-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[SecurityBundle] register alias for argument for password hasher #60371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php
Outdated
Show resolved
Hide resolved
2216356 to
576f604
Compare
Member
Author
|
@nicolas-grekas I addressed your comments, added tests, and updated CHANGELOG.md |
576f604 to
9b50bc9
Compare
src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php
Outdated
Show resolved
Hide resolved
9b50bc9 to
c6051e3
Compare
nicolas-grekas
approved these changes
May 14, 2025
chalasr
approved these changes
May 14, 2025
Member
chalasr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍
fabpot
requested changes
May 29, 2025
c6051e3 to
c1d73b1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
chalasr
requested changes
Jun 11, 2025
stof
approved these changes
Jun 11, 2025
Member
|
Thank you @lyrixx. |
This was referenced Oct 27, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new feature, but I want to gather feedback before finishing the PR (meta + doc + test)
I need to hash some sensitive data in my database (2FA recovery code).
They are not tied to a specific class. So I need a "raw hasher".
ATM, I'm able to write:
But to get it, I need to write:
There is an extra steps here (low of demeter...)
With this PR, I propose an alternative:
DX is extra smooth. If I forgot the
TargetAttribute: