[PropertyInfo] Deprecate Type
#59902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think your tests should expect deprecations as well by using the |
mtarld
force-pushed
the
fix/deprecate-property-info-type
branch
from
efaf7fe to
a9d3291
Compare
Contributor
Author
|
Indeed, that'll be great! Updated. |
chalasr
reviewed
Mar 3, 2025
src/Symfony/Bridge/Doctrine/Tests/PropertyInfo/DoctrineExtractorTest.php
Outdated
Show resolved
Hide resolved
chalasr
reviewed
Mar 3, 2025
mtarld
force-pushed
the
fix/deprecate-property-info-type
branch
from
a9d3291 to
3decf95
Compare
chalasr
approved these changes
Mar 6, 2025
mtarld
force-pushed
the
fix/deprecate-property-info-type
branch
from
3decf95 to
f819aed
Compare
OskarStark
reviewed
Mar 22, 2025
Member
|
Thank you @mtarld. |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jun 6, 2025
This PR was merged into the 8.0 branch. Discussion ---------- [PropertyInfo] Remove PropertyInfo's `Type` | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT Remove code deprecated in #59902 Commits ------- 2024789 [PropertyInfo] Remove deprecated code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new attempt to #53160, now that
symfony/type-infois not experimental anymore.Deprecates:
Typeclass in favor of theTypeclass ofsymfony/type-infoPropertyTypeExtractorInterface::getTypes()in favor of thePropertyTypeExtractorInterface::getType()methodConstructorArgumentTypeExtractorInterface::getTypesFromConstructor()in favor of theConstructorArgumentTypeExtractorInterface::getTypeFromConstructor()methodThe work for upgrading dependent packages has begun already:
TypeofTypeInfoinstead ofPropertyInfoapi-platform/core#6979PropertyTypeExtractorInterface::getTypes()deprecation, use TypeInfo ^7.2Typeux#2607