[TypeInfo] Add Type::traverse() method
#59845
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
how often do you deal with types without distinguishing whether it is a union type, an intersection type, a nullable type, etc... ? |
Contributor
Author
|
I'm currently migrating PropertyInfo's type to TypeInfo's type in API Platform, and such use cases occur quite often: // retrieve all class names of a type
foreach ($type instanceof CompositeTypeInterface ? $type->getTypes() : [$type] as $t) {
while ($t instanceof WrappingTypeInterface) {
$t = $t->getWrappedType();
}
if ($t instanceof ObjectType) {
$classNames[] = $t->getClassName();
}
}This involves either composite, wrapped and regular types. Using the // retrieve all class names of a type
foreach ($type->traverse() as $t) {
if ($t instanceof ObjectType) {
$classNames[] = $t->getClassName();
}
} |
mtarld
force-pushed
the
feat/type-info-traverse
branch
from
1855ec1 to
6d6d8b0
Compare
chalasr
approved these changes
Mar 6, 2025
Member
chalasr
left a comment
chalasr
left a comment
There was a problem hiding this comment.
Fine by me as we have a legit use case in API Platform
nicolas-grekas
approved these changes
Mar 23, 2025
fabpot
approved these changes
Mar 24, 2025
fabpot
force-pushed
the
feat/type-info-traverse
branch
from
6d6d8b0 to
6872336
Compare
Member
|
Cherry-picked by hand, not sure what happened during merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Type::traverse()method, that'll help a lot in terms of DX. Indeed, instead of writing the following:it'll only be needed to write:
Traversable can be configured with
$traverseCompositeand$traverseWrappedparameters.