[DoctrineBridge] Fix deprecation with doctrine/dbal ^4.3#59798
Merged
Conversation
Member
|
Thank you @alexandre-daubois. |
Member
|
@alexandre-daubois shouldn't this be solved at the ORM level instead so that this join column annotation stays optional ? |
Member
Author
|
@stof I'm not sure. OneToOne relations are nullable so this deprecation makes sense when a OneToOne is used as a primary key. It forces to set it explicitly as not nullable. Dealing with this at ORM level would mean making OneToOne implicitly not-nullable when used as identity columns if I understand correctly, which doesn't seem ideal as it brings "inconsistent" behavior on OneToOne columns I would say? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes deprecations raised by doctrine/dbal#6787.