[FrameworkBundle] Add support for info on ArrayNodeDefinition::canBeEnabled() and ArrayNodeDefinition::canBeDisabled()
#59630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
canbeenabled-info
branch
from
00dddda to
2dab0af
Compare
…Enabled()` and `ArrayNodeDefinition::canBeDisabled()`
alexandre-daubois
force-pushed
the
canbeenabled-info
branch
from
2dab0af to
857b778
Compare
GromNaN
approved these changes
Jan 27, 2025
Member
|
Thank you @alexandre-daubois. |
stof
reviewed
Jan 28, 2025
| public function canBeEnabled(/* ?string $info = null */): static | ||
| { | ||
| $this | ||
| $node = $this |
Member
There was a problem hiding this comment.
I would name it enabledNode to make the code more readable for next contributors about which node is stored in that variable.
Member
Author
There was a problem hiding this comment.
I agree with you, I'll take care of it. Thanks for pointing it out!
GromNaN
added a commit
that referenced
this pull request
Jan 29, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [Config] Clarify var name | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT After #59630 (comment) Commits ------- 0e4d875 [Config] Clarify var name
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #59628 (comment) (cc @GromNaN), supersedes #59628 is merged.