[DependencyInjection] Fix checking for interfaces in ContainerBuilder::getReflectionClass() #58822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch "5.4 or 7.2, TBD". Cheers! Carsonbot |
carsonbot
changed the title
Member
|
This looks like a bugfix to me. Please target 5.4. |
donquixote
force-pushed
the
issue-58821-ContainerBuilder-support-interfaces
branch
from
6f2be11 to
1c3690b
Compare
Contributor
Author
Let's see if there is consensus that this is a bug fix. |
Member
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
LGTM after some minor changes
| $classReflector = $resource->isFresh(0) ? false : new \ReflectionClass($class); | ||
| } else { | ||
| $classReflector = class_exists($class) ? new \ReflectionClass($class) : false; | ||
| $classReflector = (class_exists($class) || interface_exists($class)) ? new \ReflectionClass($class) : false; |
Member
There was a problem hiding this comment.
Suggested change
| $classReflector = (class_exists($class) || interface_exists($class)) ? new \ReflectionClass($class) : false; | |
| $classReflector = class_exists($class) || interface_exists($class, false) ? new \ReflectionClass($class) : false; |
nicolas-grekas
changed the title
…ainerBuilder::getReflectionClass().
nicolas-grekas
force-pushed
the
issue-58821-ContainerBuilder-support-interfaces
branch
from
1c3690b to
6166e8f
Compare
Member
|
Thank you @donquixote. |
This was referenced Nov 27, 2024
Merged
Merged
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
ContainerBuilder::getReflectionClass()supports interfaces only ifsymfony/configpackage is present.With this fix, it will do so without
symfony/config.Not sure how to do this.
All tests run in the monorepo, with all packages present, so
class_exists(ClassExistenceResource::class)will always be TRUE.To make this testable, we should make the condition dependent on resource tracking.
This is TBD.
This change would enable autowire for some services where this was previously not the case.