Pass validator.translation_domain to RequestPayloadValueResolver
#58187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphael-geffroy
changed the title
OskarStark
changed the title
validator.translation_domain to RequestPayloadValueResolver
Contributor
OskarStark
changed the title
validator.translation_domain to RequestPayloadValueResolvervalidator.translation_domain to RequestPayloadValueResolver
carsonbot
changed the title
validator.translation_domain to RequestPayloadValueResolvervalidator.translation_domain to RequestPayloadValueResolver
nicolas-grekas
approved these changes
Sep 6, 2024
mtarld
approved these changes
Sep 9, 2024
xabbuh
reviewed
Sep 10, 2024
src/Symfony/Component/HttpKernel/Controller/ArgumentResolver/RequestPayloadValueResolver.php
Show resolved
Hide resolved
| private readonly SerializerInterface&DenormalizerInterface $serializer, | ||
| private readonly ?ValidatorInterface $validator = null, | ||
| private readonly ?TranslatorInterface $translator = null, | ||
| private ?string $translationDomain = null, |
Member
There was a problem hiding this comment.
updated to
Suggested change
| private ?string $translationDomain = null, | |
| private string $translationDomain = 'validators', |
Member
|
Thank you @raphael-geffroy. |
Member
|
If
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces hardcoded validation translation domain by container param
validator.translation_domain.Used UploadValidatorExtension as inspiration.