[HttpKernel] Remove @internal flag and add @final to ServicesResetter
#57246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyrech
approved these changes
May 30, 2024
OskarStark
reviewed
Jun 1, 2024
src/Symfony/Component/HttpKernel/DependencyInjection/ServicesResetter.php
Show resolved
Hide resolved
fabpot
requested changes
Jun 3, 2024
src/Symfony/Component/HttpKernel/DependencyInjection/ServicesResetter.php
Show resolved
Hide resolved
lyrixx
force-pushed
the
open-service-resetter
branch
from
78b308e to
6b1032f
Compare
lyrixx
changed the title
@internal flag from ServicesResetter@internal flag and add @final to ServicesResetter
nicolas-grekas
approved these changes
Jun 3, 2024
fabpot
approved these changes
Jun 3, 2024
Member
|
Thank you @lyrixx. |
nicolas-grekas
added a commit
that referenced
this pull request
Jun 30, 2025
…rStark) This PR was squashed before being merged into the 8.0 branch. Discussion ---------- [HttpKernel] Make `ServicesResetter` class `final` | Q | A | ------------- | --- | Branch? | 8.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | -- | License | MIT Follows * #57246 Commits ------- 5fff774 [HttpKernel] Make `ServicesResetter` class `final`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this class for ages! I moved many of my internal "hack" to symfony (messenger, etc)
But there are still a lot of use cases where we could need this class:
Anyway, I used this class, and I never noticed it was internal. And today, I showed this class to @pyrech
and its IDE displayed the class in strikethrough! (vscode does not do that...)
So I think it's time to open this class.