-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[Serializer] Fixed "Warning: Attempt to read property "value" on string" #54851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serializer] Fixed "Warning: Attempt to read property "value" on string" #54851
Conversation
|
Hey! Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1.0-BETA1". Cheers! Carsonbot |
xabbuh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we cover this change with a test to prevent future regressions?
I'll try tomorrow. |
|
This is a reproduce code at the moment: |
|
@xabbuh I gave up. Could you help me ? |
58fccef to
eda1dfc
Compare
|
thanks for the snippet, I was able to create a test based on it 👍 |
eda1dfc to
975d64c
Compare
975d64c to
90251c9
Compare
|
Thank you @michaljusiega. |
|
Thank you too @xabbuh ! |
Hi! I've updated my project to
7.1.0-BETA1and I found an error.After update I got:
Warning: Attempt to read property "value" on stringinvendor/symfony/serializer/Normalizer/AbstractObjectNormalizer.php:748because in733 linethe enum-case of valueTypeIdentifierhas been already readed.Quite not sure if tests are possible here.