[AssetMapper] Using ?specifier=* does not match unstable packages on jsdelivr #52119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
commented
Oct 17, 2023
| HttpClientInterface $httpClient = null, | ||
| private readonly string $versionUrlPattern = self::URL_PATTERN_VERSION, | ||
| private readonly string $distUrlPattern = self::URL_PATTERN_DIST, | ||
| private readonly string $distUrlCssPattern = self::URL_PATTERN_DIST_CSS |
Member
Author
There was a problem hiding this comment.
Unrelated: but it really doesn't make sense to have these URLs configurable. We are hitting very exact URLs.
weaverryan
force-pushed
the
asset-mapper-fix-jsdelivr-specifier-wildcard
branch
from
f1b6ca8 to
4d6f72e
Compare
stof
approved these changes
Oct 18, 2023
weaverryan
force-pushed
the
asset-mapper-fix-jsdelivr-specifier-wildcard
branch
from
4d6f72e to
370f6dc
Compare
nicolas-grekas
added
the
❄️ Feature Freeze
fabpot
approved these changes
Oct 20, 2023
Member
|
Thank you @weaverryan. |
Contributor
|
I put this in the PR, but it probably belongs here in the issue instead. Installing the bootstrap styling of datatables.net is failing for me. symfony new assetmapper-bug --webapp --version=next --php=8.2 && cd assetmapper-bug
composer config extra.symfony.allow-contrib true
composer req symfony/asset-mapper:^6.4
bin/console importmap:require datatables.net-bs5 |
Member
Author
I'm on it - thanks :) |
fabpot
added a commit
that referenced
this pull request
Oct 20, 2023
… import then export are adjacent (weaverryan) This PR was merged into the 6.4 branch. Discussion ---------- [AssetMapper] Fixing bug of bad parsing of imports when an import then export are adjacent | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | See #52119 (comment) though this appears to be unrelated to that PR | License | MIT There should be a finite number of import statement formats. `@tacman` found a new one! :) Cheers! Commits ------- e5bd7d0 [AssetMapper] Fixing bug of bad parsing of imports when an import then export are adjacent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To find which version of a package to grab, we use this API endpoint - https://data.jsdelivr.com/v1/packages/npm/@tabler/core/resolved. If a version constraint is specified (e.g.
importmap:require 'bootstrap@^5'), we add a?specifier=5. If no version is specified, previously we added?specifier=*. However, this seems to ignore beta releases (returningnullfor@table/core, whose only has a 1.0 beta). Omitting?specifierseems to grab the latest, no matter what it is.Also, if for some reason, we still can't find a
version, we know blow up with a much clearer exception.Cheers!