[Cache] Fix support for Redis Sentinel using php-redis 6.0.0 #51683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qonstrukt
commented
Sep 18, 2023
| 'host' => $host, | ||
| 'port' => $port, | ||
| 'connectTimeout' => $params['timeout'], | ||
| 'persistent' => $params['persistent_id'], |
Contributor
Author
There was a problem hiding this comment.
There is no connect or pconnect call using RedisSentinel. So the decision of being persistent or not is being take by this value being null or set to a string. Not sure why it was converted to string before, but this works perfectly fine on my environment (without persistence) at least.
stof
reviewed
Sep 18, 2023
Qonstrukt
force-pushed
the
php-redis-6-support
branch
from
47c3103 to
91bcc05
Compare
nicolas-grekas
force-pushed
the
php-redis-6-support
branch
from
91bcc05 to
9423c71
Compare
Member
|
Thank you @Qonstrukt. |
This was referenced Sep 28, 2023
nicolas-grekas
added a commit
that referenced
this pull request
Sep 28, 2023
This PR was merged into the 6.4 branch. Discussion ---------- [Cache] Fix two initializations of Redis Sentinel | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT After #51687 and #51683 have been merged, there are now two initializations of Redis Sentinel, which also leads to the integration test failure mentioned in [this comment](#51687 (comment)). This PR fixes this. Commits ------- 2d23a1b [Cache] Fix two initializations of Redis Sentinel
This was referenced Nov 17, 2023
nicolas-grekas
added a commit
that referenced
this pull request
Nov 21, 2023
… 6.0.0 (pepeh) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [Messenger] Fix support for Redis Sentinel using php-redis 6.0.0 | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #52487 | License | MIT Added support for [php-redis 6.0.0](https://github.com/phpredis/phpredis/blob/develop/CHANGELOG.md#600---2023-09-09-github-pecl) to Symfony/Component/Messenger/Bridge/Redis/Transport/Connection. A similar fix was done for RedisTrait before: #51683 Commits ------- 42a80db [Messenger] Fix support for Redis Sentinel using php-redis 6.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for php-redis 6.0.0 to
Symfony/Component/Cache/Traits/RedisTrait.Made changes to how
RedisSentinelis constructed, which now uses the same constructor as the mainRedisclass. Didn't find any other changes that might be relevant yet, but it's why I mention Redis Sentinel explicitly.