[HttpClient] Favor php-http/discovery instead of nyholm/psr7 #50225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
hc-plug
branch
2 times, most recently
from
78b2c47 to
ee66e15
Compare
stof
reviewed
May 3, 2023
| $this->checkClass($use); | ||
| } | ||
| if (isset(self::$deprecated[$use]) && strncmp($vendor, str_replace('_', '\\', $use), $vendorLen) && !isset(self::$deprecated[$class]) | ||
| && !(HttplugClient::class === $class && \in_array($use, [\Http\Client\HttpClient::class, \Http\Message\RequestFactory::class, \Http\Message\StreamFactory::class, \Http\Message\UriFactory::class], true)) |
Member
There was a problem hiding this comment.
Great that we don't need to do special cases here anymore
stof
reviewed
May 3, 2023
nicolas-grekas
added
the
❄️ Feature Freeze
stof
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fine-tunes the DX related to using
HttplugClientandPsr18Client.By favoring
php-http/discovery, we build on its latest capabilities to use whatever implementation might be installed and preferred by the app.Of course, we keep
nyholm/psr7as a privileged PSR-7 implementation so that when it's installed butphp-http/discoveryis not, things keep working as usual.The deprecated interfaces from
php-http/message-factoryare also moved to a new conditional and internalLegacyHttplugInterface, so that we can make this dependency optional.