Skip to content

[HttpClient] Deprecation Contracts Dependency#47873

Merged
derrabus merged 1 commit intosymfony:6.2from
MGatner:patch-1
Oct 15, 2022
Merged

[HttpClient] Deprecation Contracts Dependency#47873
derrabus merged 1 commit intosymfony:6.2from
MGatner:patch-1

Conversation

@MGatner
Copy link
Copy Markdown
Contributor

@MGatner MGatner commented Oct 15, 2022

Q A
Branch? 6.2 (branch follow-up)
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR

I believe ca3a246 added deprecation-contracts to the incorrect field, which is causing the actual package not to install in some circumstances because it thinks HTTPClient provides the dependency.

@carsonbot
Copy link
Copy Markdown

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title Deprecation Contracts Dependency [HttpClient] Deprecation Contracts Dependency Oct 15, 2022
@derrabus
Copy link
Copy Markdown
Member

Good catch, thanks @MGatner.

@derrabus derrabus merged commit 889f4d6 into symfony:6.2 Oct 15, 2022
@MGatner
Copy link
Copy Markdown
Contributor Author

MGatner commented Oct 15, 2022

💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants