[HttpClient][WebProfilerBundle] Catch errors when encoding body for c… #46570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! I think @Deuchnord has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
pl-github
force-pushed
the
http-client-web-profiler-fix-encoding-errors
branch
from
03cc221 to
36e6fa0
Compare
nicolas-grekas
approved these changes
Jun 9, 2022
Member
|
Thank you @pl-github. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Symfony 6.1 a button to copy a request as a cURL command was introduced for the profiler.
But if I post a binary file containing null characters using the curl-http-client the
HttpClientDataCollectorthrows an error.My solution is to catch the
ValueErrorin this situation and to returnnullas the resulting curl command. Returningnullseems to be the standard handling for unexpectad values in this data collector.