Skip to content

Conversation

@RTUnreal
Copy link
Contributor

@RTUnreal RTUnreal commented Mar 7, 2022

Q A
Branch? 4.4, 5.4, 6.0, 6.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets none
License MIT
Doc PR none

Make icons centered in trace list and not on the bottom trace-line-header div

Before:
grafik
After:
grafik

Make icons centered in trace list and not on the bottom trace-line-header div
@RTUnreal RTUnreal requested a review from yceruto as a code owner March 7, 2022 13:32
@carsonbot carsonbot added this to the 4.4 milestone Mar 7, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

I think @awoimbee has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@carsonbot carsonbot changed the title Center icons vertically in trace list [ErrorHandler] Center icons vertically in trace list Mar 8, 2022
@fabpot
Copy link
Member

fabpot commented Mar 12, 2022

Thank you @RTUnreal.

@fabpot fabpot merged commit f1f123b into symfony:4.4 Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants