[symfony/mailjet-mailer] Fix invalid mailjet error managment #45564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamirault
changed the title
|
Hey! I think @tcheymol has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
fancyweb
reviewed
Mar 2, 2022
src/Symfony/Component/Mailer/Bridge/Mailjet/Tests/Transport/MailjetApiTransportTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/Mailjet/Tests/Transport/MailjetApiTransportTest.php
Outdated
Show resolved
Hide resolved
fancyweb
reviewed
Mar 9, 2022
src/Symfony/Component/Mailer/Bridge/Mailjet/Tests/Transport/MailjetApiTransportTest.php
Outdated
Show resolved
Hide resolved
alamirault
force-pushed
the
fix-45420-invalid-mailjet-error-managment
branch
from
5c0095a to
e83abc2
Compare
fancyweb
approved these changes
Mar 10, 2022
fabpot
approved these changes
Mar 12, 2022
fabpot
force-pushed
the
fix-45420-invalid-mailjet-error-managment
branch
from
e83abc2 to
aa1e12c
Compare
Member
|
Thank you @alamirault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mailjet API status code is not 200, response is structured (see-below) and is not currently well managed.
Example of bad request response:
{ "Messages": [ { "Status": "error", "Errors": [ { "ErrorIdentifier": "8e28ac9c-1fd7-41ad-825f-1d60bc459189", "ErrorCode": "mj-0005", "StatusCode": 400, "ErrorMessage": "The To is mandatory but missing from the input", "ErrorRelatedTo": ["To"] } ] } ] }This PR fix
Undefined index: Messageand add unit tests.