[WIP] failing test for HEAD StreamedResponse requests #4502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
Well a HEAD can't/shouldn't be streamed as it doesn't contain a body so what is the real problem here? |
Contributor
Author
|
@sstok the response is prepared by the ResponseListener regardless of request method |
Contributor
|
Shouldn't the test at least assert something ? |
fabpot
added a commit
that referenced
this pull request
Jun 13, 2012
Commits ------- 280fc05 failing test for HEAD StreamedResponse requests Discussion ---------- [WIP] failing test for HEAD StreamedResponse requests An exception is thrown if you prepare a StreamedResponse with a HEAD request. I'm not sure what the right fix is… --------------------------------------------------------------------------- by kriswallsmith at 2012-06-06T15:51:04Z The Travis build is here: http://travis-ci.org/#!/symfony/symfony/builds/1543352 --------------------------------------------------------------------------- by sstok at 2012-06-08T11:07:31Z Well a HEAD can't/shouldn't be streamed as it doesn't contain a body so what is the real problem here? --------------------------------------------------------------------------- by kriswallsmith at 2012-06-08T16:14:18Z @sstok the response is prepared by the ResponseListener regardless of request method --------------------------------------------------------------------------- by adrienbrault at 2012-06-08T19:41:27Z Shouldn't the test at least assert something ?
arnaud-lb
added a commit
to arnaud-lb/symfony
that referenced
this pull request
Mar 14, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An exception is thrown if you prepare a StreamedResponse with a HEAD request. I'm not sure what the right fix is…