Skip to content

Use str_ends_with() and str_starts_with() #44499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GromNaN merged 1 commit into from
Dec 7, 2021
Merged

Use str_ends_with() and str_starts_with() #44499

GromNaN merged 1 commit into from
Dec 7, 2021

Conversation

@alexislefebvre
Copy link
Contributor

@alexislefebvre alexislefebvre commented Dec 7, 2021

Q A
Branch? 6.1
Bug fix? no
New feature? no
Deprecations? no
Tickets no
License MIT
Doc PR no

Use str_ends_with() and str_starts_with() instead of substr().

(replaces #44482 and #44476 🥲)

@alexislefebvre alexislefebvre mentioned this pull request Dec 7, 2021
Closed
@GromNaN GromNaN force-pushed the use-str-starts-end-with branch from 2557cba to 28d4d6b Compare December 7, 2021 23:54
@GromNaN GromNaN merged commit 6ab662b into symfony:6.1 Dec 7, 2021
@GromNaN
Copy link
Member

GromNaN commented Dec 7, 2021

Thank you @alexislefebvre

@alexislefebvre alexislefebvre deleted the use-str-starts-end-with branch December 8, 2021 00:06
@alexislefebvre alexislefebvre mentioned this pull request Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GromNaN GromNaN GromNaN approved these changes

@derrabus derrabus derrabus approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@lyrixx lyrixx Awaiting requested review from lyrixx lyrixx is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexislefebvre @GromNaN @derrabus