Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Yaml] revert using functions provided by polyfill packages #43944

Merged
merged 1 commit into from
Nov 5, 2021
Merged

[Yaml] revert using functions provided by polyfill packages #43944

merged 1 commit into from
Nov 5, 2021

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 5, 2021

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #43943
License MIT
Doc PR

This reverts #41431 for the same reason for which we merged #42296 (see #42280 and composer/composer#10024 for more information).

@xabbuh xabbuh added this to the 5.4 milestone Nov 5, 2021
@xabbuh xabbuh mentioned this pull request Nov 5, 2021
Closed
nicolas-grekas
nicolas-grekas approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fabbot and good

derrabus
derrabus approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's re-revert this change on 6.0, please.

I realized that array_is_list() is a PHP 8.1 feature. Forget what I just wrote. 🙈

@fabpot
Copy link
Member

fabpot commented Nov 5, 2021

Thank you @xabbuh.

@fabpot fabpot merged commit ff8aae7 into symfony:5.4 Nov 5, 2021
@xabbuh xabbuh deleted the issue-43943 branch November 5, 2021 20:15
@dmaicher
Copy link
Contributor

dmaicher commented Nov 5, 2021

Thanks for the fast fix @xabbuh 😊

This was referenced Nov 14, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot

@nicolas-grekas nicolas-grekas

@stof stof

@derrabus derrabus

Assignees
No one assigned
Labels
Bug Status: Reviewed Yaml
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[Yaml] Call to undefined function Symfony\Component\Yaml\array_is_list()
7 participants
@xabbuh @fabpot @dmaicher @nicolas-grekas @stof @derrabus @carsonbot