[HttpFoundation] Fix PHP 8.1 deprecation notice in IpUtils::checkIp() #43357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
👍🏻 But let's fix this on 4.4. |
W0rma
force-pushed
the
43350-php81-iputils
branch
from
46a72ed to
870ea00
Compare
Contributor
Author
Thank you for the hint. I rebased against 4.4 |
derrabus
approved these changes
Oct 7, 2021
W0rma
force-pushed
the
43350-php81-iputils
branch
from
870ea00 to
5e991db
Compare
chalasr
approved these changes
Oct 8, 2021
fabpot
approved these changes
Oct 10, 2021
Member
|
Thank you @W0rma. |
Member
|
@W0rma Can you work on the followup PRs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this PR got merged I will create additional PRs to deprecate (5.4)/remove (6.0) passing
nullto various methods inIpUtilslike suggested in #43350 (comment)