[HttpFoundation] Remove implicit float to int cast #42783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander M. Turek <[email protected]>
fabpot
approved these changes
Aug 30, 2021
Member
|
Thank you @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a test that triggers a deprecation warning on PHP 8.1. On 5.4 and below, the test made sure that if the caller passed a float value (despite the doc block demanding an integer) an explicit cast to int would be performed.
On the 6.0 branch, that cast has been removed because we've added a parameter type declaration that does not allow floats. Because the type cast is implicit now, PHP 8.1 triggers a deprecation when the case would mean a loss of precision. Since the test tested undocumented behavior anyway, I decided to remove it.