Fix SplFileInfo mock in HttpKernelBrowserTest
#42618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
force-pushed
the
bugfix/fix-spl-file-info-mock-in-http-kernel-browser-test
branch
from
1e85dd5 to
f44a9d1
Compare
herndlm
changed the title
SplFileInfo mock in HttpKernelBrowserTest`SplFileInfo mock in HttpKernelBrowserTest
herndlm
force-pushed
the
bugfix/fix-spl-file-info-mock-in-http-kernel-browser-test
branch
from
f44a9d1 to
ad0c933
Compare
Contributor
Author
|
No idea why the high-deps fail, should not be related 🤔 |
herndlm
force-pushed
the
bugfix/fix-spl-file-info-mock-in-http-kernel-browser-test
branch
from
ad0c933 to
6990458
Compare
herndlm
changed the title
SplFileInfo mock in HttpKernelBrowserTestSplFileInfo mock in HttpKernelBrowserTest
derrabus
approved these changes
Aug 18, 2021
carsonbot
changed the title
SplFileInfo mock in HttpKernelBrowserTestSplFileInfo mock in HttpKernelBrowserTest
fabpot
approved these changes
Aug 18, 2021
Member
|
Thank you @herndlm. |
herndlm
deleted the
bugfix/fix-spl-file-info-mock-in-http-kernel-browser-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSizereturnsint|falseand cannot be mocked withINFwhich is float.Fixes the failing test in PHP 8.1.