-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[ExpressionLanguage] [Lexer] Remove PHP 8.0 polyfill #42585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
Hey! I think @Andrej-in-ua has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Can you please share a link or some details about why this change is needed for you? |
Sure @nicolas-grekas . I am having this problem in a TYPO3 installation. I am using the TYPO3-Console and during the first installation thanks to this package the Typo3InstallAction is executed and and the error occurs right here Hope this helps, let me know if I can do something more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should apply this change to 4.4 then.
Linking to composer/composer#10024 for references. |
Thank you @nigelmann. |
This is a partial revert of #41576 and is a followup to #42296