Skip to content

[ExpressionLanguage] [Lexer] Remove PHP 8.0 polyfill #42585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

nigelmann
Copy link
Contributor

Q A
Branch 5.3
Bug fix yes
New feature no
Deprecations no
Tickets Fix #42280
License MIT
Doc PR N/A

This is a partial revert of #41576 and is a followup to #42296

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title [ExpressionLanguage][Lexer] Remove PHP 8.0 polyfill [ExpressionLanguage] [Lexer] Remove PHP 8.0 polyfill Aug 16, 2021
@OskarStark OskarStark requested a review from derrabus August 16, 2021 16:37
@carsonbot
Copy link

Hey!

I think @Andrej-in-ua has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

Can you please share a link or some details about why this change is needed for you?

@derrabus derrabus removed their request for review August 18, 2021 14:51
@nigelmann
Copy link
Contributor Author

Sure @nicolas-grekas .

I am having this problem in a TYPO3 installation. I am using the TYPO3-Console and during the first installation thanks to this package the Typo3InstallAction is executed and and the error occurs right here

Hope this helps, let me know if I can do something more

@derrabus derrabus modified the milestones: 5.3, 4.4 Aug 18, 2021
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should apply this change to 4.4 then.

@nicolas-grekas
Copy link
Member

Linking to composer/composer#10024 for references.

@nicolas-grekas
Copy link
Member

Thank you @nigelmann.

@nicolas-grekas nicolas-grekas merged commit 6ccc63f into symfony:4.4 Aug 19, 2021
This was referenced Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants