Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dotenv][Yaml] Remove PHP 8.0 polyfill #42296

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

derrabus
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #42280
License MIT
Doc PR N/A

This is a partial revert of #41576 and #41973.

Signed-off-by: Alexander M. Turek <me@derrabus.de>
@derrabus derrabus requested a review from xabbuh as a code owner July 27, 2021 16:26
@carsonbot carsonbot added this to the 4.4 milestone Jul 27, 2021
@carsonbot carsonbot changed the title [DotEnv][Yaml] Remove PHP 8.0 polyfill [Dotenv][Yaml] Remove PHP 8.0 polyfill Jul 27, 2021
@crmpicco
Copy link

Great work. Keen to see this merged in and released.

@YohannsMonnier
Copy link

YohannsMonnier commented Jul 28, 2021

Dear @derrabus , this fix should also apply to 5.3.5 too.

@derrabus
Copy link
Member Author

No worries, we're merging everything up.

@fabpot
Copy link
Member

fabpot commented Jul 29, 2021

Thank you @derrabus.

@fabpot fabpot merged commit 192e360 into symfony:4.4 Jul 29, 2021
This was referenced Jul 29, 2021
@derrabus derrabus deleted the bugfix/remove-polyfills branch July 29, 2021 08:26
@nicolas-grekas
Copy link
Member

Linking to composer/composer#10024 for references.

nicolas-grekas added a commit that referenced this pull request Aug 19, 2021
…lmann)

This PR was submitted for the 5.3 branch but it was merged into the 4.4 branch instead.

Discussion
----------

[ExpressionLanguage] [Lexer] Remove PHP 8.0 polyfill

| Q             | A
| ------------- | ---
| Branch       | 5.3
| Bug fix      | yes
| New feature  | no
| Deprecations | no
| Tickets       | Fix #42280
| License       | MIT
| Doc PR        | N/A

This is a partial revert of #41576 and is a followup to #42296

Commits
-------

d2f39e9 Remove polyfills from ExpressionLanguage
fabpot added a commit that referenced this pull request Nov 5, 2021
…s (xabbuh)

This PR was merged into the 5.4 branch.

Discussion
----------

[Yaml] revert using functions provided by polyfill packages

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #43943
| License       | MIT
| Doc PR        |

This reverts #41431 for the same reason for which we merged #42296 (see #42280 and composer/composer#10024 for more information).

Commits
-------

3b9b700 revert using functions provided by polyfill packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symfony 4.4.27 upgrade falls over on PHP 7.4 when calling str_contains
7 participants