[Messenger] Fix broken mock #41558
Merged
[Messenger] Fix broken mock #41558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
approved these changes
Jun 6, 2021
Nyholm
reviewed
Jun 6, 2021
src/Symfony/Component/Messenger/Bridge/AmazonSqs/Tests/Transport/AmazonSqsTransportTest.php
Outdated
Show resolved
Hide resolved
Signed-off-by: Alexander M. Turek <[email protected]>
derrabus
force-pushed
the
bugfix/messenger-broken-mock
branch
from
c254d3b to
7d1435b
Compare
Member
|
Thank you @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reality,
$response->getInfo('http_code')will always yield an integer, but the mock created inAmazonSqsTransportTestwill returnnull. This causes trouble on PHP 8.1 because the status code is eventually passed as$codeto an exception constructor that does not allownullvalues anymore.