Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Yaml] Leverage array_is_list() #41431

Merged
merged 1 commit into from
Jun 2, 2021
Merged

[Yaml] Leverage array_is_list() #41431

merged 1 commit into from
Jun 2, 2021

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented May 28, 2021 •
edited
Loading

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas added this to the 4.4 milestone May 28, 2021
@nicolas-grekas nicolas-grekas requested a review from xabbuh as a code owner May 28, 2021 08:44
javiereguiluz
javiereguiluz approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely 😍

@Nyholm
Copy link
Member

Nyholm commented May 31, 2021

Is this really a bugfix?

Ie, why not target 5.4?

@nicolas-grekas
Copy link
Member Author

To save some potential merge conflicts, and benefit from the work on the polyfill I guess.

stof
stof approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is consistent with the way we introduced usage of get_debug_type where we relied on the polyfill in older branches too.

@nicolas-grekas
Copy link
Member Author

this is consistent with the way we introduced usage of get_debug_type where we relied on the polyfill in older branches too.

ooch, actually we added get_debug_type() only on recent branches! That reverses the argument, updating for 5.4... :)

@nicolas-grekas nicolas-grekas changed the base branch from 4.4 to 5.4 June 1, 2021 10:05
@nicolas-grekas nicolas-grekas modified the milestones: 4.4, 5.4 Jun 1, 2021
@nicolas-grekas nicolas-grekas merged commit 2fe4442 into symfony:5.4 Jun 2, 2021
@nicolas-grekas nicolas-grekas deleted the array-list branch June 3, 2021 14:12
@xabbuh xabbuh mentioned this pull request Nov 5, 2021
Merged
fabpot added a commit that referenced this pull request Nov 5, 2021
@fabpot
bug #43944 [Yaml] revert using functions provided by polyfill package…
ff8aae7 
…s (xabbuh)

This PR was merged into the 5.4 branch.

Discussion
----------

[Yaml] revert using functions provided by polyfill packages

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #43943
| License       | MIT
| Doc PR        |

This reverts #41431 for the same reason for which we merged #42296 (see #42280 and composer/composer#10024 for more information).

Commits
-------

3b9b700 revert using functions provided by polyfill packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiereguiluz javiereguiluz

@stof stof

@derrabus derrabus

@xabbuh xabbuh

Assignees
No one assigned
Labels
Status: Reviewed Yaml
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@nicolas-grekas @Nyholm @javiereguiluz @stof @derrabus @carsonbot