Update src/Symfony/Component/Console/Input/InputOption.php #4062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you add some unit tests? |
Contributor
Author
|
Will do this week |
Member
|
@nanocom Any update for this PR? |
Contributor
Author
|
Sorry lack of time will try to do it this week |
Contributor
Author
|
Opened a new PR based on my fork |
craigmarvelley
pushed a commit
to craigmarvelley/symfony
that referenced
this pull request
Nov 26, 2013
Commits ------- 2c19b3c Empty shortcut check in the constructor cf9039e Added a unit test for the shortcut name of the InputOption class Discussion ---------- [Console] Single dash for option shortcuts See symfony#4062 --------------------------------------------------------------------------- by travisbot at 2012-05-20T13:09:18Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1380389) (merged 02290da4 into f433f6b). --------------------------------------------------------------------------- by stof at 2012-05-20T13:16:34Z please rebase your branch to get rid of these merge commits btw, you should use feature branches to send your next pull requests instead of using your master branch each time, which limits you to a single PR. --------------------------------------------------------------------------- by Nanocom at 2012-05-20T13:39:32Z Sorry for the mess, cleaning it --------------------------------------------------------------------------- by travisbot at 2012-05-20T13:41:46Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1380549) (merged 63129657 into f433f6b). --------------------------------------------------------------------------- by travisbot at 2012-05-20T13:43:07Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1380553) (merged 2c19b3c into f433f6b).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just make sure that an option constructed with the exact shortcut "-" has a null shortcut.