[Messenger] extract worker logic to listener and get rid of SendersLocatorInterface::getSenderByAlias #34185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobion
force-pushed
the
messenger-refactoring
branch
5 times, most recently
from
72f2480 to
3a2672f
Compare
Tobion
changed the title
Tobion
commented
Oct 31, 2019
| use Symfony\Component\Messenger\Transport\Sender\SendersLocator; | ||
| use Symfony\Component\Messenger\Worker; | ||
|
|
||
| class RetryIntegrationTest extends TestCase |
Contributor
Author
There was a problem hiding this comment.
fully covered by FailureIntegrationTest
Tobion
force-pushed
the
messenger-refactoring
branch
from
3a2672f to
4b5547a
Compare
weaverryan
reviewed
Oct 31, 2019
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
Absolutely wonderful.
This removes some "evil" (added by me 👿) without any downside that I can see. It's simply a cleaner implementation - moving several "special cases" like the RedeliveryStamp handling - out of core classes like Worker and SendMessageMiddleware and into event listeners.
src/Symfony/Component/Messenger/EventListener/SendFailedMessageForRetryListener.php
Show resolved
Hide resolved
src/Symfony/Component/Messenger/EventListener/SendFailedMessageForRetryListener.php
Show resolved
Hide resolved
src/Symfony/Component/Messenger/EventListener/SendFailedMessageToFailureTransportListener.php
Show resolved
Hide resolved
src/Symfony/Component/Messenger/EventListener/SendFailedMessageForRetryListener.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Messenger/Command/AbstractFailedMessagesCommand.php
Outdated
Show resolved
Hide resolved
Tobion
force-pushed
the
messenger-refactoring
branch
from
4b5547a to
71a18ac
Compare
and failure directly to transport instead of redispatching on the bus
Tobion
force-pushed
the
messenger-refactoring
branch
from
71a18ac to
d7e0f98
Compare
weaverryan
approved these changes
Nov 1, 2019
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
+1
Test failures match failures on current 4.4 or things that should resolve after merge afaik (like FWBundle from this PR failing against symfony/messenger:dev-master due to a class added in this PR missing).
Tobion
added a commit
that referenced
this pull request
Nov 1, 2019
…id of SendersLocatorInterface::getSenderByAlias (Tobion) This PR was merged into the 4.4 branch. Discussion ---------- [Messenger] extract worker logic to listener and get rid of SendersLocatorInterface::getSenderByAlias | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | Fix #32077 and #31848 | License | MIT | Doc PR | as discussed with @weaverryan sending messages for retry and failure directly to transport instead of redispatching on the bus makes things much cleaner Commits ------- d7e0f98 [Messenger] extract worker logic to listener and sent messages for retry and failure directly to transport instead of redispatching on the bus
Contributor
|
The test |
Contributor
Author
|
It's getting fixed in #34217 |
This was referenced Nov 12, 2019
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Oct 20, 2025
This PR was merged into the 7.4 branch. Discussion ---------- [Messenger] Simplify code | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Noticed while working on #61843. There's no reason for the event to be dispatched inside the loop anymore: 1. The event was [originally dispatched outside the loop](#30650). 2. It was later [moved inside the loop](#30676) because of the retry mechanism. 3. [The retry mechanism was later extracted](#34185), so there's no longer a need for the event to be dispatched inside the loop. Commits ------- beeb4b9 [Messenger] Simplify code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed with @weaverryan sending messages for retry and failure directly to transport instead of redispatching on the bus makes things much cleaner