[String] Introduce a locale-aware Slugger in the String component #33768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgalopin
force-pushed
the
string-slugger
branch
from
7836ea6 to
cc8687a
Compare
yceruto
reviewed
Sep 30, 2019
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
tgalopin
force-pushed
the
string-slugger
branch
from
cc8687a to
f051ddc
Compare
stof
reviewed
Oct 1, 2019
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
tgalopin
force-pushed
the
string-slugger
branch
9 times, most recently
from
26c170a to
e6c9ff3
Compare
nicolas-grekas
approved these changes
Oct 2, 2019
tgalopin
force-pushed
the
string-slugger
branch
2 times, most recently
from
5491b6f to
9c0b619
Compare
nicolas-grekas
approved these changes
Oct 2, 2019
javiereguiluz
approved these changes
Oct 2, 2019
Member
javiereguiluz
left a comment
javiereguiluz
left a comment
There was a problem hiding this comment.
I love this! This will be immensely useful 😍 Thanks Titouan!
tgalopin
force-pushed
the
string-slugger
branch
from
9c0b619 to
abed321
Compare
…h FrameworkBundle wiring
tgalopin
force-pushed
the
string-slugger
branch
from
abed321 to
056d8ce
Compare
Member
|
Thank you @tgalopin. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 2, 2019
…g component (tgalopin) This PR was merged into the 5.0-dev branch. Discussion ---------- [String] Introduce a locale-aware Slugger in the String component | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This PR introduces a locale-aware Slugger in the new String component, based on transliterators provided by the PHP intl extension (or iconv if not available). It also wires this Slugger in the FrameworkBundle in order to use it easily as a service and to automatically inject the proper locale into it to choose the appropriate transliteration depending on the Request locale. See https://github.com/unicode-org/cldr/tree/master/common/transforms for CLDR mappings. Commits ------- 056d8ce [String] Introduce a locale-aware Slugger in the String component with FrameworkBundle wiring
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a locale-aware Slugger in the new String component, based on transliterators provided by the PHP intl extension (or iconv if not available). It also wires this Slugger in the FrameworkBundle in order to use it easily as a service and to automatically inject the proper locale into it to choose the appropriate transliteration depending on the Request locale.
See https://github.com/unicode-org/cldr/tree/master/common/transforms for CLDR mappings.