[ErrorRenderer] Fix timestamp on logs view #33013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Aug 7, 2019
yceruto
approved these changes
Aug 7, 2019
| <td class="text-small" nowrap> | ||
| <span class="colored text-bold"><?= $this->escape($log['priorityName']); ?></span> | ||
| <span class="text-muted newline"><?= (new \DateTime($log['timestamp']))->format('H:i:s'); ?></span> | ||
| <span class="text-muted newline"><?= (new \DateTime())->setTimestamp($log['timestamp'])->format('H:i:s'); ?></span> |
Member
There was a problem hiding this comment.
for short date('H:i:s', $log['timestamp'])?
Contributor
Author
There was a problem hiding this comment.
Yes, it's more readable 😃
oliverquynh
approved these changes
Aug 7, 2019
maxhelias
force-pushed
the
fix-log-datetime
branch
from
005c382 to
a0ad2d0
Compare
Member
|
Thank you @maxhelias. |
yceruto
added a commit
that referenced
this pull request
Aug 7, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [ErrorRenderer] Fix timestamp on logs view | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | - | License | MIT | Doc PR | - This syntax raises a php exception : ```php (new \DateTime($log['timestamp']))->format('H:i:s'); ``` ``` <br /> <b>Fatal error</b>: Uncaught Exception: DateTime::__construct(): Failed to parse time string (1565179387) at position 7 (3): Unexpected character in [...][...]:4 Stack trace: #0 [...][...](4): DateTime->__construct('1565179387') #1 {main} thrown in <b>[...][...]</b> on line <b>4</b><br /> ``` Commits ------- a0ad2d0 [ErrorRenderer] Fix timestamp on logs view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This syntax raises a php exception :