Skip to content

[Serializer] Fix DataUriNormalizer docblock & composer suggest section #31922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Jun 7, 2019
Merged

[Serializer] Fix DataUriNormalizer docblock & composer suggest section #31922

nicolas-grekas merged 1 commit into from
Jun 7, 2019
+2 −2

Conversation

@ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Jun 7, 2019

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes/no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

See

symfony/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php

Lines 135 to 139 in 9691519

if ($this->mimeTypeGuesser && $mimeType = $this->mimeTypeGuesser->guess($object->getPathname())) {
return $mimeType;
}
return 'application/octet-stream';

@ogizanagi ogizanagi requested a review from dunglas as a code owner June 7, 2019 08:56
@ogizanagi ogizanagi mentioned this pull request Jun 7, 2019
Merged
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jun 7, 2019

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit 51b6bd8 into symfony:3.4 Jun 7, 2019
nicolas-grekas added a commit that referenced this pull request Jun 7, 2019
@nicolas-grekas
minor #31922 [Serializer] Fix DataUriNormalizer docblock & composer s…
50b3ba9 
…uggest section (ogizanagi)

This PR was merged into the 3.4 branch.

Discussion
----------

[Serializer] Fix DataUriNormalizer docblock & composer suggest section

| Q             | A
| ------------- | ---
| Branch?       | 3.4  <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | yes/no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

See
https://github.com/symfony/symfony/blob/9691519ca46511005bc701ca93c2973923952034/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php#L135-L139

Commits
-------

51b6bd8 [Serializer] Fix DataUriNormalizer docblock & composer suggest section
@ogizanagi ogizanagi deleted the fix/serializer/data-uri-docblock branch June 7, 2019 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees

No one assigned

Labels

Serializer Status: Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ogizanagi @nicolas-grekas @carsonbot