[WIP][Serializer]Use PropertyInfo to extract properties #28775
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
requested changes
Oct 8, 2018
Member
dunglas
left a comment
dunglas
left a comment
There was a problem hiding this comment.
Awesome, it will allow to dramatically simplify the component, then to improve its performance.
src/Symfony/Component/PropertyInfo/Tests/Extractor/ReflectionExtractorTest.php
Outdated
Show resolved
Hide resolved
| $properties = array(); | ||
| foreach ($reflectionProperties as $reflectionProperty) { | ||
| if ($reflectionProperty->isPublic()) { | ||
| if ($reflectionProperty->isPublic() && (!($context[self::EXCLUDE_STATIC_PROPERTIES] ?? false) || !$reflectionProperty->isStatic())) { |
Member
There was a problem hiding this comment.
It almost looks like a bug to me that we used to include static properties. I would like to change the default behavior and add a flag to include static props instead, but it's maybe to late (BC break). WDYT @symfony/deciders?
Member
There was a problem hiding this comment.
Yeah, I am afraid changing that would be a BC break.
src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php
Outdated
Show resolved
Hide resolved
…clude public static properties
dunglas
approved these changes
Nov 8, 2018
xabbuh
requested changes
Nov 8, 2018
fbourigault
changed the title
1 task
Contributor
Author
|
I’m closing this PR because I don’t plan to work on it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactoring to reduce the complexity of the ObjectNormalizer. It now use a
PropertyListExtractorInterfaceto get the class properties list.To achieve this, I also added a
exclude_static_propertiesoption to theReflectionExtractor::getPropertiesmethod.Starting from this PR,
symfony/serializerhas a hard dependency onsymfony/property-info.This was exposed by @dunglas in #19374 (comment).
To do
exclude_static_properties.