Harden the debugging of Twig filters and functions#22994
Merged
fabpot merged 1 commit intosymfony:2.7from May 31, 2017
Merged
Conversation
Removing the environment and context arguments is now based on Twig metadata rather than on some wild guessing which might go wrong.
Merged
|
|
||
| return !$param->getClass() || $param->getClass()->getName() !== 'Twig_Environment'; | ||
| }); | ||
| if ($type === 'filters') { |
Member
There was a problem hiding this comment.
let's use yoda-style then :)
Member
Author
There was a problem hiding this comment.
none of the conditions in this class are using yoda-style actually
Member
|
Thank you @stof. |
fabpot
added a commit
that referenced
this pull request
May 31, 2017
This PR was merged into the 2.7 branch. Discussion ---------- Harden the debugging of Twig filters and functions | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Removing the environment and context arguments is now based on Twig metadata rather than on some wild guessing which might go wrong: - the environment argument may not be typehinted - the context argument may not be named `$context` - an argument may be named `$context` without being the special context argument Commits ------- 63a8aff Harden the debugging of Twig filters and functions
This was referenced Jun 5, 2017
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing the environment and context arguments is now based on Twig metadata rather than on some wild guessing which might go wrong:
$context$contextwithout being the special context argument