Skip to content

Conversation

@chalasr
Copy link
Member

@chalasr chalasr commented Mar 21, 2017

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #21373
License MIT
Doc PR n/a

To ease upgrading.

We could also add something like that in the framework application:

public function findNamespace($namespace)
{
    try {
        return parent::findNamespace($namespace);
    } catch (CommandNotFoundException $e) {
        if ('server' === $namespace) {
            throw new CommandNotFoundException('The "server:start", "server:stop", "server:status" and "server:run" commands have been moved...');
        }
    }
}

But AFAIK we never did so in the past, tell me if we should.

@chalasr chalasr changed the title [FrameworkBundle] Document removal of server:* commands from the framework [FrameworkBundle] Document removal of server:* commands Mar 21, 2017
@fabpot
Copy link
Member

fabpot commented Mar 21, 2017

Thank you @chalasr.

@fabpot fabpot merged commit c99641a into symfony:master Mar 21, 2017
fabpot added a commit that referenced this pull request Mar 21, 2017
…(chalasr)

This PR was merged into the 3.3-dev branch.

Discussion
----------

[FrameworkBundle] Document removal of server:* commands

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21373
| License       | MIT
| Doc PR        | n/a

To ease upgrading.

We could also add something like that in the framework application:
```php
public function findNamespace($namespace)
{
    try {
        return parent::findNamespace($namespace);
    } catch (CommandNotFoundException $e) {
        if ('server' === $namespace) {
            throw new CommandNotFoundException('The "server:start", "server:stop", "server:status" and "server:run" commands have been moved...');
        }
    }
}
```
But AFAIK we never did so in the past, tell me if we should.

Commits
-------

c99641a Document removal of server:* commands from the framework
@chalasr chalasr deleted the webserver-upgrade branch March 21, 2017 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants