[FrameworkBundle] Add missing resource tracking for validation mapping #21927
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Mar 8, 2017
| $files['yaml' === $extension ? 'yml' : $extension][] = $path; | ||
| } else { | ||
| throw new \RuntimeException(sprintf('Unsupported mapping type in "%s", supported types are XML & Yaml.', $path)); | ||
| if ($container->fileExists($path)) { |
Member
There was a problem hiding this comment.
content needs to be tracked for directories (but only for new XML and YAML files). But it does not need to be tracked for files (changing the content of the validation file does not need to invalidate the container). So this shoould be improved.
Member
Author
There was a problem hiding this comment.
updated. Could you please have a look?
| if ($container->fileExists($path)) { | ||
| if (is_dir($path)) { | ||
| $this->getValidatorMappingFilesFromDir($path, $files); | ||
| } elseif (is_file($path)) { |
chalasr
force-pushed
the
validation-resource-track
branch
3 times, most recently
from
eccbc76 to
2435069
Compare
chalasr
force-pushed
the
validation-resource-track
branch
from
2435069 to
0a19cbe
Compare
Member
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Mar 9, 2017
…tion mapping (chalasr) This PR was merged into the 3.3-dev branch. Discussion ---------- [FrameworkBundle] Add missing resource tracking for validation mapping | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19086 (comment) | License | MIT | Doc PR | n/a https://github.com/symfony/symfony/pull/21927/files?w=1 Commits ------- 0a19cbe Add missing resource tracking for validation mapping
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/symfony/symfony/pull/21927/files?w=1