Skip to content

[Console] SfStyleTest: Remove COLUMNS env on tearDown #21456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Jan 30, 2017
Merged

[Console] SfStyleTest: Remove COLUMNS env on tearDown #21456

nicolas-grekas merged 1 commit into from
Jan 30, 2017

Conversation

@ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Jan 29, 2017

Q A
Branch? 3.2
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #21424 (comment)
License MIT
Doc PR N/A

@ogizanagi ogizanagi mentioned this pull request Jan 29, 2017
Merged
@ogizanagi ogizanagi changed the title [Console] SfStyleTest: Remove COLUMN env on tearDown [Console] SfStyleTest: Remove COLUMNS env on tearDown Jan 29, 2017
@ogizanagi ogizanagi changed the base branch from master to 3.2 January 29, 2017 19:49
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jan 30, 2017

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit b715a36 into symfony:3.2 Jan 30, 2017
nicolas-grekas added a commit that referenced this pull request Jan 30, 2017
@nicolas-grekas
minor #21456 [Console] SfStyleTest: Remove COLUMNS env on tearDown (o…
4aebd3a 
…gizanagi)

This PR was merged into the 3.2 branch.

Discussion
----------

[Console] SfStyleTest: Remove COLUMNS env on tearDown

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21424 (comment)
| License       | MIT
| Doc PR        | N/A

Commits
-------

b715a36 [Console] SfStyleTest: Remove COLUMN env on tearDown
@ogizanagi ogizanagi deleted the fix/console/test/sf_style/col_reset branch January 30, 2017 13:40
@stof
Copy link
Member

stof commented Jan 30, 2017

would be even better to reset it to the previous value if there was one

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jan 30, 2017

COLUMN is a special env var you cannot really set in fact (try in bash), so removing is fine to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Console Status: Needs Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ogizanagi @nicolas-grekas @stof @carsonbot