[VarDumper] Added support for SplFileInfo #14424

lyrixx · 2015-04-20T21:43:27Z

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	~
License	MIT
Doc PR	~

Before:

SplFileInfo {#3}

After:

SplFileInfo {#3
  path: "/home/greg/dev/github.com/lyrixx/gaga-photo/fixtures"
  filename: "grisou.jpg"
  basename: "grisou.jpg"
  pathname: "/home/greg/dev/github.com/lyrixx/gaga-photo/fixtures/grisou.jpg"
  extension: "jpg"
  realPath: "/home/greg/dev/github.com/lyrixx/gaga-photo/fixtures/grisou.jpg"
  aTime: 2015-04-20 23:21:15
  mTime: 2014-08-17 15:37:36
  cTime: 2015-04-20 23:09:51
  inode: 12197643
  size: 966553
  perms: 0100750
  owner: 1000
  group: 1000
  type: "file"
  writable: true
  readable: true
  executable: true
  file: true
  dir: false
  link: false
}

For a link:

SplFileInfo {#3
  path: ""
  filename: "link"
  basename: "link"
  pathname: "link"
  extension: ""
  realPath: "/home/greg/dev/github.com/symfony/var-dumper/composer.json"
  aTime: 2015-04-20 23:39:15
  mTime: 2015-04-20 23:39:15
  cTime: 2015-04-20 23:39:15
  inode: 11272232
  size: 967
  perms: 0100644
  owner: 1000
  group: 1000
  type: "link"
  writable: true
  readable: true
  executable: false
  file: true
  dir: false
  link: true
  linkTarget: "composer.json"
}

For a remote file:

SplFileInfo {#3
  path: "http://google.com"
  filename: "foobar.php"
  basename: "foobar.php"
  pathname: "http://google.com/foobar.php"
  extension: "php"
  realPath: false
  writable: false
  readable: false
  executable: false
  file: false
  dir: false
  link: false
}

For a CSV:

SplFileObject {#3
  path: ""
  filename: "test.csv"
  basename: "test.csv"
  pathname: "test.csv"
  extension: "csv"
  realPath: "/home/greg/dev/github.com/symfony/var-dumper/test.csv"
  aTime: 2015-04-21 12:55:07
  mTime: 2015-04-21 12:55:07
  cTime: 2015-04-21 12:55:07
  inode: 11272237
  size: 0
  perms: 0100644
  owner: 1000
  group: 1000
  type: "file"
  writable: true
  readable: true
  executable: false
  file: true
  dir: false
  link: false
  csvControl: array:2 [
    0 => ","
    1 => """
  ]
  flags: SKIP_EMPTY|READ_CSV
  maxLineLen: 0
  fstat: array:7 [
    "dev" => 64513
    "ino" => 11272237
    "nlink" => 1
    "rdev" => 0
    "blksize" => 4096
    "blocks" => 0
    "…" => "…20"
  ]
  eof: false
  key: 0
}

dunglas · 2015-04-21T05:00:23Z

👍

lyrixx · 2015-04-21T09:27:15Z

I also added support for SplFileObject

stof · 2015-04-21T09:45:56Z

What about tests ?

javiereguiluz · 2015-04-21T09:47:55Z

👍 this is great @lyrixx!

I have a proposal: could it be possible to show some of the information in a human-friendly way? Example:

Symfony\Component\Finder\SplFileInfo {#69
  basename: "grisou.jpg"
  filename: "grisou.jpg"
  extension: "jpg"
  path: "fixtures"
  pathname: "fixtures/grisou.jpg"
  realPath: "/home/greg/dev/github.com/lyrixx/gaga-photo/fixtures/grisou.jpg"
  perms: 33256 (rwxr-xr-x)
  inode: 12197643
  size: 966553 bytes (0.96 MB)
  owner: 1000
  group: 1000
  aTime: 1429564875 (April 20, 2015 23:21:15)
  mTime: 1408282656 (August 17, 2014 15:37:36)
  cTime: 1429564191 (April 20, 2015 23:09:51)
  type: "file"
  writable: true
  readable: true
  executable: true
  file: true
  dir: false
  link: false
}

Changes:

All the filename, extension, path, etc. properties are grouped at the beginning.
File size is showed in the original bytes length and in the "human size" (MB, KB, etc.)
Dates are displayed in the original timestamp and in understandable format.
Perms are also transformed to the usual human format.

lyrixx · 2015-04-21T10:01:12Z

@javiereguiluz Oups, I did not updated the "sample" but most of your comments are already addressed.

Green-Cat · 2015-04-21T10:08:54Z

👍

javiereguiluz · 2015-04-21T10:14:29Z

@lyrixx awesome! Thanks.

lyrixx · 2015-04-21T10:15:02Z

@javiereguiluz I updated the description, and move some "property"

aitboudad · 2015-04-21T10:38:27Z

👍

lyrixx · 2015-04-21T10:57:33Z

I had to rework the implementation to not throw exception when the file is special (link a remote file)

stof · 2015-04-21T11:53:20Z

-1 until tests are not added (I'm putting an explicit -1 vote here as other voters seems to validate it without tests, which is not a good idea).

Otherwise, the idea is good

lyrixx · 2015-04-21T12:53:45Z

@stof you should be happy now ;)

lyrixx · 2015-04-21T14:07:06Z

Travis is green, but fabbot is KO...

nicolas-grekas · 2015-04-21T17:11:45Z

👍

stof · 2015-04-21T17:14:28Z

@lyrixx it would be great to avoid setting non-working links in the fabbot commit status for pending builds (either not setting the URL if Travis supports it, or making the page valid, saying that the inspection is in progress)

stof · 2015-04-21T17:20:03Z

👍

@lyrixx what about adding the support for Symfony\Component\Finder\SplFileInfo too, which adds the relative path too ?

lyrixx · 2015-04-21T18:08:22Z

@stof It's already supported because the VarDumper is awesome ;)
(It starts by casting the "higher" extended class to finish by the current class, and because the Symfony\Component\Finder\SplFileInfo is "just" a regular class with private attribute, it just works)

<?php

require __DIR__.'/vendor/autoload.php';

$f = new Symfony\Component\Finder\SplFileInfo(__FILE__, 'relativePath', 'relativePathname');
die(dump($f));

=>

Symfony\Component\Finder\SplFileInfo {#4
  -relativePath: "relativePath"
  -relativePathname: "relativePathname"
  path: "/home/greg/dev/github.com/symfony/symfony"
  filename: "test.php"
  basename: "test.php"
  pathname: "/home/greg/dev/github.com/symfony/symfony/test.php"
  extension: "php"
  realPath: "/home/greg/dev/github.com/symfony/symfony/test.php"
  aTime: 2015-04-21 20:05:29
  mTime: 2015-04-21 20:05:27
  cTime: 2015-04-21 20:05:27
  inode: 12851779
  size: 157
  perms: 0100644
  owner: 1000
  group: 1000
  type: "file"
  writable: true
  readable: true
  executable: false
  file: true
  dir: false
  link: false
}

nicolas-grekas · 2015-04-22T09:38:41Z

Thank you @lyrixx.

This PR was merged into the 2.8 branch. Discussion ---------- [VarDumper] Added support for SplFileInfo | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Before: ``` SplFileInfo {#3} ``` After: ``` SplFileInfo {#3 path: "/home/greg/dev/github.com/lyrixx/gaga-photo/fixtures" filename: "grisou.jpg" basename: "grisou.jpg" pathname: "/home/greg/dev/github.com/lyrixx/gaga-photo/fixtures/grisou.jpg" extension: "jpg" realPath: "/home/greg/dev/github.com/lyrixx/gaga-photo/fixtures/grisou.jpg" aTime: 2015-04-20 23:21:15 mTime: 2014-08-17 15:37:36 cTime: 2015-04-20 23:09:51 inode: 12197643 size: 966553 perms: 0100750 owner: 1000 group: 1000 type: "file" writable: true readable: true executable: true file: true dir: false link: false } ``` For a link: ``` SplFileInfo {#3 path: "" filename: "link" basename: "link" pathname: "link" extension: "" realPath: "/home/greg/dev/github.com/symfony/var-dumper/composer.json" aTime: 2015-04-20 23:39:15 mTime: 2015-04-20 23:39:15 cTime: 2015-04-20 23:39:15 inode: 11272232 size: 967 perms: 0100644 owner: 1000 group: 1000 type: "link" writable: true readable: true executable: false file: true dir: false link: true linkTarget: "composer.json" } ``` For a remote file: ``` SplFileInfo {#3 path: "http://google.com" filename: "foobar.php" basename: "foobar.php" pathname: "http://google.com/foobar.php" extension: "php" realPath: false writable: false readable: false executable: false file: false dir: false link: false } ``` For a CSV: ``` SplFileObject {#3 path: "" filename: "test.csv" basename: "test.csv" pathname: "test.csv" extension: "csv" realPath: "/home/greg/dev/github.com/symfony/var-dumper/test.csv" aTime: 2015-04-21 12:55:07 mTime: 2015-04-21 12:55:07 cTime: 2015-04-21 12:55:07 inode: 11272237 size: 0 perms: 0100644 owner: 1000 group: 1000 type: "file" writable: true readable: true executable: false file: true dir: false link: false csvControl: array:2 [ 0 => "," 1 => """ ] flags: SKIP_EMPTY|READ_CSV maxLineLen: 0 fstat: array:7 [ "dev" => 64513 "ino" => 11272237 "nlink" => 1 "rdev" => 0 "blksize" => 4096 "blocks" => 0 "…" => "…20" ] eof: false key: 0 } Commits ------- e75c233 [VarDumper] Added support for SplFileObject eb50b13 [VarDumper] Added support for SplFileInfo

lyrixx force-pushed the vd-SplFileInfo branch from b6f4e93 to ef72b3e Compare April 20, 2015 22:18

lyrixx force-pushed the vd-SplFileInfo branch from ef72b3e to 4a88329 Compare April 21, 2015 09:26

lyrixx force-pushed the vd-SplFileInfo branch from 4a88329 to 8eaea76 Compare April 21, 2015 10:13

lyrixx force-pushed the vd-SplFileInfo branch 2 times, most recently from cd4c132 to 8c21de4 Compare April 21, 2015 10:38

aitboudad added the VarDumper label Apr 21, 2015

lyrixx force-pushed the vd-SplFileInfo branch 2 times, most recently from 3783f52 to 07d8151 Compare April 21, 2015 10:53

[VarDumper] Added support for SplFileInfo

eb50b13

lyrixx force-pushed the vd-SplFileInfo branch from 07d8151 to fc551b9 Compare April 21, 2015 12:53

lyrixx force-pushed the vd-SplFileInfo branch from fc551b9 to fffa79a Compare April 21, 2015 13:00

[VarDumper] Added support for SplFileObject

e75c233

lyrixx force-pushed the vd-SplFileInfo branch from fffa79a to e75c233 Compare April 21, 2015 13:00

nicolas-grekas merged commit e75c233 into symfony:2.8 Apr 22, 2015

lyrixx deleted the vd-SplFileInfo branch April 22, 2015 09:43

fabpot mentioned this pull request Nov 16, 2015

Release v2.8.0-BETA1 #16550

Merged

Uh oh!

[VarDumper] Added support for SplFileInfo #14424

[VarDumper] Added support for SplFileInfo #14424

Uh oh!

Conversation

lyrixx commented Apr 20, 2015

Uh oh!

dunglas commented Apr 21, 2015

Uh oh!

lyrixx commented Apr 21, 2015

Uh oh!

stof commented Apr 21, 2015

Uh oh!

javiereguiluz commented Apr 21, 2015

Uh oh!

lyrixx commented Apr 21, 2015

Uh oh!

Green-Cat commented Apr 21, 2015

Uh oh!

javiereguiluz commented Apr 21, 2015

Uh oh!

lyrixx commented Apr 21, 2015

Uh oh!

aitboudad commented Apr 21, 2015

Uh oh!

lyrixx commented Apr 21, 2015

Uh oh!

stof commented Apr 21, 2015

Uh oh!

lyrixx commented Apr 21, 2015

Uh oh!

lyrixx commented Apr 21, 2015

Uh oh!

nicolas-grekas commented Apr 21, 2015

Uh oh!

stof commented Apr 21, 2015

Uh oh!

stof commented Apr 21, 2015

Uh oh!

lyrixx commented Apr 21, 2015

Uh oh!

nicolas-grekas commented Apr 22, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants