[ErrorHandler] Do not patch return types that are not a valid PHP type

wouterj · wouterj · commit fa7703ba4a70 · 2022-07-28T12:03:39.000+02:00
diff --git a/src/Symfony/Component/ErrorHandler/DebugClassLoader.php b/src/Symfony/Component/ErrorHandler/DebugClassLoader.php
@@ -853,6 +853,11 @@ private function setReturnType(string $types, string $class, string $method, str
                 return;
             }
 
+            if (!preg_match('/^(?:\\\\?[a-zA-Z_\x80-\xff][a-zA-Z0-9_\x80-\xff]*)+$/', $n)) {
+                // exclude any invalid PHP class name (e.g. `Cookie::SAMESITE_*`)
+                continue;
+            }
+
             if (!isset($phpTypes[''])) {
                 $phpTypes[] = $n;
             }

Original file line number	Diff line number	Diff line change
`@@ -853,6 +853,11 @@ private function setReturnType(string $types, string $class, string $method, str`
`853`	`853`	`return;`
`854`	`854`	`}`
`855`	`855`
	`856`	`+ if (!preg_match('/^(?:\\\\?[a-zA-Z_\x80-\xff][a-zA-Z0-9_\x80-\xff]*)+$/', $n)) {`
	`857`	+ // exclude any invalid PHP class name (e.g. `Cookie::SAMESITE_*`)
	`858`	`+ continue;`
	`859`	`+ }`
	`860`	`+`
`856`	`861`	`if (!isset($phpTypes[''])) {`
`857`	`862`	`$phpTypes[] = $n;`
`858`	`863`	`}`