Skip to content

Commit f21dab2

Browse files
wouterjwouterj
committed
Added error badge
1 parent 111a404 commit f21dab2

File tree

1 file changed

+31
-28
lines changed
  • src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector

1 file changed

+31
-28
lines changed

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/form.html.twig‎

Lines changed: 31 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,22 @@
9797
.hidden {
9898
display: none;
9999
}
100+
.btn-toggle {
101+
cursor: pointer;
102+
}
103+
.badge-error {
104+
float: right;
105+
background: #a33;
106+
color: #fff;
107+
padding: 1px 4px;
108+
font-size: 10px;
109+
vertical-align: middle;
110+
border-radius: 6px;
111+
}
112+
.table-error th {
113+
background: #a33;
114+
color: #fff;
115+
}
100116
</style>
101117

102118
{% if collector.data.forms|length %}
@@ -142,20 +158,8 @@
142158
};
143159
144160
this.toggle = function (element) {
145-
var r;
146-
147-
if (element.style.display !== 'none') {
148-
// this.collapse(element);
149-
150-
r = 'collapse';
151-
} else {
152-
// this.expand(element);
153-
}
154-
155161
var imgs = element.parentElement.getElementsByTagName('img');
156162
Sfjs.toggle(element, imgs[0], imgs[1]);
157-
158-
return r || 'expand';
159163
}
160164
}
161165
@@ -168,11 +172,7 @@
168172
var buttons = tree.querySelectorAll('.toggle-button');
169173
for (var j = 0, l = buttons.length; j < l; j++) {
170174
buttons[j].addEventListener('click', function (e) {
171-
if ('collapse' === treeView.toggle(this.parentElement.parentElement.querySelector('ul'))) {
172-
this.textContent = '+';
173-
} else {
174-
this.textContent = '-';
175-
}
175+
treeView.toggle(this.parentElement.parentElement.querySelector('ul'));
176176
}, false);
177177
}
178178
@@ -266,6 +266,9 @@
266266
<img class="toggle-button" src="{{ asset('bundles/framework/images/blue_picto_full.gif') }}">
267267
{% endif %}
268268
{{ name }}
269+
{% if data.errors is defined and data.errors|length > 0 %}
270+
<div class="badge-error">{{ data.errors|length }}</div>
271+
{% endif %}
269272
</div>
270273

271274
{% if data.children is not empty %}
@@ -290,7 +293,7 @@
290293
{% if data.errors is defined and data.errors|length > 0 %}
291294
<h3>Errors</h3>
292295

293-
<table>
296+
<table class="table-error">
294297
<tr>
295298
<th width="50%">Message</th>
296299
<th>Cause</th>
@@ -306,11 +309,11 @@
306309

307310
{% if data.default_data is defined %}
308311
<h3>
309-
<a onclick="toggle('{{ data.id }}', 'default_data')">
312+
Default Data
313+
<a class="btn-toggle" onclick="toggle('{{ data.id }}', 'default_data')">
310314
<img style="display:none" id="{{ data.id }}-default_data-open" src="{{ asset('bundles/framework/images/blue_picto_more.gif') }}">
311315
<img style="display:inline" id="{{ data.id }}-default_data-close" src="{{ asset('bundles/framework/images/blue_picto_less.gif') }}">
312316
</a>
313-
Default Data
314317
</h3>
315318

316319
<div id="{{ data.id }}-default_data">
@@ -345,11 +348,11 @@
345348

346349
{% if data.submitted_data is defined %}
347350
<h3>
348-
<a onclick="toggle('{{ data.id }}', 'submitted_data')">
351+
Submitted Data
352+
<a class="btn-toggle" onclick="toggle('{{ data.id }}', 'submitted_data')">
349353
<img style="display:none" id="{{ data.id }}-submitted_data-open" src="{{ asset('bundles/framework/images/blue_picto_more.gif') }}">
350354
<img style="display:inline" id="{{ data.id }}-submitted_data-close" src="{{ asset('bundles/framework/images/blue_picto_less.gif') }}">
351355
</a>
352-
Submitted Data
353356
</h3>
354357

355358
<div id="{{ data.id }}-submitted_data">
@@ -388,11 +391,11 @@
388391

389392
{% if data.passed_options is defined %}
390393
<h3>
391-
<a onclick="toggle('{{ data.id }}', 'passed_options')">
394+
Passed Options
395+
<a class="btn-toggle" onclick="toggle('{{ data.id }}', 'passed_options')">
392396
<img style="display:none" id="{{ data.id }}-passed_options-open" src="{{ asset('bundles/framework/images/blue_picto_more.gif') }}">
393397
<img style="display:inline" id="{{ data.id }}-passed_options-close" src="{{ asset('bundles/framework/images/blue_picto_less.gif') }}">
394398
</a>
395-
Passed Options
396399
</h3>
397400

398401
<div id="{{ data.id }}-passed_options">
@@ -425,11 +428,11 @@
425428

426429
{% if data.resolved_options is defined %}
427430
<h3>
428-
<a onclick="toggle('{{ data.id }}', 'resolved_options')">
431+
Resolved Options
432+
<a class="btn-toggle" onclick="toggle('{{ data.id }}', 'resolved_options')">
429433
<img style="display:inline" id="{{ data.id }}-resolved_options-open" src="{{ asset('bundles/framework/images/blue_picto_more.gif') }}">
430434
<img style="display:none" id="{{ data.id }}-resolved_options-close" src="{{ asset('bundles/framework/images/blue_picto_less.gif') }}">
431435
</a>
432-
Resolved Options
433436
</h3>
434437

435438
<div id="{{ data.id }}-resolved_options" style="display:none">
@@ -450,11 +453,11 @@
450453

451454
{% if data.view_vars is defined %}
452455
<h3>
453-
<a onclick="toggle('{{ data.id }}', 'view_vars')">
456+
View Variables
457+
<a class="btn-toggle" onclick="toggle('{{ data.id }}', 'view_vars')">
454458
<img style="display:inline" id="{{ data.id }}-view_vars-open" src="{{ asset('bundles/framework/images/blue_picto_more.gif') }}">
455459
<img style="display:none" id="{{ data.id }}-view_vars-close" src="{{ asset('bundles/framework/images/blue_picto_less.gif') }}">
456460
</a>
457-
View Variables
458461
</h3>
459462

460463
<div id="{{ data.id }}-view_vars" style="display:none">

0 commit comments

Comments
 (0)