bug #44514 Don't access uninitialized typed property ChromePhpHandler::$response (Philipp91)

fancyweb · fancyweb · commit e4cfa82c31ff · 2021-12-09T10:00:06.000+01:00
This PR was merged into the 6.0 branch. Discussion ---------- Don't access uninitialized typed property ChromePhpHandler::$response Fixes #44513 | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | yes | Tickets | Fix #44513 | License | MIT Commits ------- da457d9 Don't access uninitialized typed property ChromePhpHandler::$response
diff --git a/src/Symfony/Bridge/Monolog/Handler/ChromePhpHandler.php b/src/Symfony/Bridge/Monolog/Handler/ChromePhpHandler.php
@@ -59,7 +59,7 @@ protected function sendHeader($header, $content): void
             return;
         }
 
-        if ($this->response) {
+        if (isset($this->response)) {
             $this->response->headers->set($header, $content);
         } else {
             $this->headers[$header] = $content;

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ protected function sendHeader($header, $content): void`
`59`	`59`	`return;`
`60`	`60`	`}`
`61`	`61`
`62`		`- if ($this->response) {`
	`62`	`+ if (isset($this->response)) {`
`63`	`63`	`$this->response->headers->set($header, $content);`
`64`	`64`	`} else {`
`65`	`65`	`$this->headers[$header] = $content;`