adds cache for isPtySupported()

schmittjoh · schmittjoh · commit dbd264a7848f · 2013-08-03T16:52:29.000+02:00
diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php
@@ -127,18 +127,24 @@ class Process
      */
     public static function isPtySupported()
     {
+        static $result;
+
+        if (null !== $result) {
+            return $result;
+        }
+
         if (defined('PHP_WINDOWS_VERSION_BUILD')) {
-            return false;
+            return $result = false;
         }
 
         $proc = @proc_open('echo 1', array(array('pty'), array('pty'), array('pty')), $pipes);
         if (is_resource($proc)) {
             proc_close($proc);
 
-            return true;
+            return $result = true;
         }
 
-        return false;
+        return $result = false;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -127,18 +127,24 @@ class Process`
`127`	`127`	`*/`
`128`	`128`	`public static function isPtySupported()`
`129`	`129`	`{`
	`130`	`+ static $result;`
	`131`	`+`
	`132`	`+ if (null !== $result) {`
	`133`	`+ return $result;`
	`134`	`+ }`
	`135`	`+`
`130`	`136`	`if (defined('PHP_WINDOWS_VERSION_BUILD')) {`
`131`		`- return false;`
	`137`	`+ return $result = false;`
`132`	`138`	`}`
`133`	`139`
`134`	`140`	`$proc = @proc_open('echo 1', array(array('pty'), array('pty'), array('pty')), $pipes);`
`135`	`141`	`if (is_resource($proc)) {`
`136`	`142`	`proc_close($proc);`
`137`	`143`
`138`		`- return true;`
	`144`	`+ return $result = true;`
`139`	`145`	`}`
`140`	`146`
`141`		`- return false;`
	`147`	`+ return $result = false;`
`142`	`148`	`}`
`143`	`149`
`144`	`150`	`/**`