[Form] ResizeFormListener::preBind() now handles empty strings. Fixes #40

webmozart · webmozart · commit 95822218621d · 2011-04-15T15:43:02.000+02:00
diff --git a/src/Symfony/Component/Form/EventListener/ResizeFormListener.php b/src/Symfony/Component/Form/EventListener/ResizeFormListener.php
@@ -94,7 +94,7 @@ public function preBind(DataEvent $event)
         $form = $event->getForm();
         $data = $event->getData();
 
-        if (null === $data) {
+        if (null === $data || '' === $data) {
             $data = array();
         }
 
diff --git a/tests/Symfony/Tests/Component/Form/EventListener/ResizeFormListenerTest.php b/tests/Symfony/Tests/Component/Form/EventListener/ResizeFormListenerTest.php
@@ -183,6 +183,19 @@ public function testPreBindDealsWithNullData()
         $this->assertFalse($this->form->has('1'));
     }
 
+    // fixes https://github.com/symfony/symfony/pull/40
+    public function testPreBindDealsWithEmptyData()
+    {
+        $this->form->add($this->getForm('1'));
+
+        $data = '';
+        $event = new DataEvent($this->form, $data);
+        $listener = new ResizeFormListener($this->factory, 'text', true);
+        $listener->preBind($event);
+
+        $this->assertFalse($this->form->has('1'));
+    }
+
     public function testOnBindNormDataRemovesEntriesMissingInTheFormIfResizable()
     {
         $this->form->add($this->getForm('1'));

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ public function preBind(DataEvent $event)`
`94`	`94`	`$form = $event->getForm();`
`95`	`95`	`$data = $event->getData();`
`96`	`96`
`97`		`- if (null === $data) {`
	`97`	`+ if (null === $data \|\| '' === $data) {`
`98`	`98`	`$data = array();`
`99`	`99`	`}`
`100`	`100`